wgtmac commented on PR #1335: URL: https://github.com/apache/parquet-java/pull/1335#issuecomment-2299087459
Good question. The `ParquetRewriter` is created by the refactoring work to consolidate `ColumnEncryptor`, `ColumnMasker`, `ColumnPruner` and `CompressionConverter`. You can see individual unit test in the `ColumnEncryptorTest`, `ColumnMaskerTest`, `ColumnPrunerTest` and `CompressionConverterTest` respectively. So the main goal of `ParquetRewriterTest` is to cover the combination of these features. I think we mainly need test cases covering the new join features, and prove that it does not break when other features are turned on. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
