clairemcginty commented on code in PR #2993:
URL: https://github.com/apache/parquet-java/pull/2993#discussion_r1723253174
##########
parquet-avro/src/main/java/org/apache/parquet/avro/AvroSchemaConverter.java:
##########
@@ -605,4 +611,14 @@ private static String namespace(String name, Map<String,
Integer> names) {
Integer nameCount = names.merge(name, 1, (oldValue, value) -> oldValue +
1);
return nameCount > 1 ? name + nameCount : null;
}
+
+ /* Avro <= 1.9 does not support conversions to LocalTimestamp{Micros,
Millis} classes */
+ private static boolean avroVersionSupportsLocalTimestampTypes() {
Review Comment:
I'll give it a try with Powermock!
I might start a thread on the mailing list this week discussing Avro version
support more broadly, to formalize which Avro versions are currently
supported/any planned EOL dates? I've been thinking it would also be good to
have some automated testing of parquet-avro on different Avro versions... it
would just be a little complicated to set up since we'd need either a separate
Maven module per supported Avro version, or some very clever classloading :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
