clairemcginty commented on code in PR #2993:
URL: https://github.com/apache/parquet-java/pull/2993#discussion_r1723368105
##########
parquet-avro/src/main/java/org/apache/parquet/avro/AvroSchemaConverter.java:
##########
@@ -605,4 +611,14 @@ private static String namespace(String name, Map<String,
Integer> names) {
Integer nameCount = names.merge(name, 1, (oldValue, value) -> oldValue +
1);
return nameCount > 1 ? name + nameCount : null;
}
+
+ /* Avro <= 1.9 does not support conversions to LocalTimestamp{Micros,
Millis} classes */
+ private static boolean avroVersionSupportsLocalTimestampTypes() {
Review Comment:
I think 1.8 is a reasonable lower bound! for context on our use case, we use
the [Beam](https://github.com/apache/beam) library, which until very recently
was tightly coupled with 1.8. Things are now more flexible, but there's a lot
of inertia surrounding 1.8 -- the breaking changes surrounding logical types
make it a non-trivial upgrade 😅
I'll take a look at the hadoop setup! Avro is a bit tricky because we need
to both set the Avro-compiler version, and load the Avro core library, for
whatever version of Avro we want to test...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
