mapleFU commented on code in PR #449:
URL: https://github.com/apache/parquet-format/pull/449#discussion_r1730346673
##########
src/main/thrift/parquet.thrift:
##########
@@ -257,7 +257,14 @@ struct Statistics {
*/
1: optional binary max;
2: optional binary min;
- /** count of null value in the column */
+ /**
+ * Count of null values in the column.
+ *
+ * Writers SHOULD always write this field even if it is zero (i.e. no null
value)
+ * or the column is not nullable.
Review Comment:
> Why should writers write this field if the column isn't nullable?
I agree it's not costless in this section, however most impl uses this. It's
not a standard but it's widely used.
> (Also, if you disregard this comment, at least change the wording from not
nullable to not required, as that's the correct term w.rt. to the schema (there
is no nullable field in the schema, just a repetition type).)
You're right, I'll rechecking this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
