JFinis commented on code in PR #449:
URL: https://github.com/apache/parquet-format/pull/449#discussion_r1730337351
##########
src/main/thrift/parquet.thrift:
##########
@@ -257,7 +257,14 @@ struct Statistics {
*/
1: optional binary max;
2: optional binary min;
- /** count of null value in the column */
+ /**
+ * Count of null values in the column.
+ *
+ * Writers SHOULD always write this field even if it is zero (i.e. no null
value)
+ * or the column is not nullable.
+ * Readers MUST distinguish between null_count not being present and
null_count == 0.
+ * If null_count is not present, readers MUST NOT assume null_count == 0.
Review Comment:
What did parquet-rs do? Not write the null count in case it was null? If so,
then readers will just not optimize out null handling in this case, which seems
fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
