rdblue commented on code in PR #240:
URL: https://github.com/apache/parquet-format/pull/240#discussion_r1768979706
##########
src/main/thrift/parquet.thrift:
##########
@@ -1084,6 +1290,9 @@ struct ColumnIndex {
* Same as repetition_level_histograms except for definitions levels.
**/
7: optional list<i64> definition_level_histograms;
+
+ /** A list containing statistics of GEOMETRY logical type for each page */
+ 8: optional list<GeometryStatistics> geometry_stats;
Review Comment:
Why are there stats for each page? Each bbox is up to 64 bytes, which seems
like a lot of overhead at the page level, especially given that WKB objects are
also considerably larger than most values stored in a Parquet page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]