mkaravel commented on code in PR #240:
URL: https://github.com/apache/parquet-format/pull/240#discussion_r1768990948
##########
src/main/thrift/parquet.thrift:
##########
@@ -237,6 +237,97 @@ struct SizeStatistics {
3: optional list<i64> definition_level_histogram;
}
+/**
+ * Interpretation for edges of GEOMETRY logical type, i.e. whether the edge
+ * between points represent a straight cartesian line or the shortest line on
+ * the sphere. It applies to all non-point geometry objects.
+ */
+enum Edges {
Review Comment:
I find the term `EdgeInterpolation` quite misleading. What we seem to want
to convey here is how the edges between points are interpreted. How they are
interpreted has to do with the underlying space in which the geometry is
embedded. For example for WGS84 the edges are by definition spheroidal edges
(not spherical, which is why I have made other comments about the use of the
word `SPHERICAL`). If you have SRID 3857, then it is a planar coordinate
system. I guess the word "interpolation" could mean what you use to
_interpolate_ between vertices, but this feels like an awkward use of the word.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
