MaxNevermind commented on PR #3036:
URL: https://github.com/apache/parquet-java/pull/3036#issuecomment-2440174841

   > I asked for `column ordering` because renaming and reordering may happen 
together in the case of schema evolution. We can support them in the future 
when needed.
   
   In case of column reordering there is a need to provide a new order of 
column, correct? If I would be implementing it I guess I would create a 
RewriteOptions's option like `Map<SrcColName, Map.Entry<DistColName, 
DestColIdx>> columnsReordered` which would have merged capabilities of both 
renaming and reordering. I think current implementation can be extended to 
something like that in the future, for example if `columnsReordered` is used we 
should prohibit `renameColumns` option usage, wdyt?
   
   > I am also skeptical of this case. But it seems to be valid if one wants to 
nullify a renamed column which has sensitive data?
   
   I've just checked `MaskMode` enum, it has planned hashing feature as I 
understand. Renaming hashed column would definitely should be beneficial to 
support. Okay, I think we should try to support renaming of masked columns.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to