MaxNevermind commented on code in PR #3036:
URL: https://github.com/apache/parquet-java/pull/3036#discussion_r1818191960
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/rewrite/RewriteOptions.java:
##########
@@ -561,13 +582,29 @@ public RewriteOptions build() {
!maskColumns.containsKey(pruneColumn), "Cannot prune and mask
same column");
}
}
-
if (encryptColumns != null) {
for (String pruneColumn : pruneColumns) {
Preconditions.checkArgument(
!encryptColumns.contains(pruneColumn), "Cannot prune and
encrypt same column");
}
}
+ if (renameColumns != null) {
+ for (Map.Entry<String, String> entry : renameColumns.entrySet()) {
+ Preconditions.checkArgument(
+ !encryptColumns.contains(entry.getKey()), "Cannot prune and
rename same column");
+ }
+ }
+ }
+
+ if (renameColumns != null && !renameColumns.isEmpty()) {
+ for (Map.Entry<String, String> entry : renameColumns.entrySet()) {
Review Comment:
done
check ParquetRewriter's added method `ensureRenamedColumnsCorrectness()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
