wgtmac commented on code in PR #466:
URL: https://github.com/apache/parquet-format/pull/466#discussion_r1825643095
##########
LogicalTypes.md:
##########
@@ -655,10 +655,12 @@ should always be determined by the following rules:
1. If the repeated field is not a group, then its type is the element type and
elements are required.
2. If the repeated field is a group with multiple fields, then its type is the
- element type and elements are required.
-3. If the repeated field is a group with one field and is named either `array`
- or uses the `LIST`-annotated group's name with `_tuple` appended then the
- repeated type is the element type and elements are required.
+ element type and elements are required. In this case, the element type is
+ a Struct type with multiple fields.
+3. If the repeated field is a group (without annotation) with one `required` or
Review Comment:
I think we'd better open another PR to discuss list types without
annotation. It might be more complicated than the scope of this PR. I'm not
sure if it should be allowed by the spec even though we are able to create the
schema.
EDIT: after thinking about it again, we may add following words to the end
of the Lists section.
> Some existing data does not even have the `LIST` annotation and simply uses
> `repeated` repetition to annotate the element type. In this case, the
element
> type MUST be a primitive type and both the list and elements are required.
>
> ```
> // List<Integer> (non-null list, non-null elements)
> repeated int32 num;
>
> // Struct<List<Integer>, List<String>> (non-null list, non-null elements)
> optional group whatever {
> repeated int32 num;
> repeated binary str (STRING);
> }
> ```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
