etseidl commented on code in PR #466:
URL: https://github.com/apache/parquet-format/pull/466#discussion_r1824856711
##########
LogicalTypes.md:
##########
@@ -655,10 +655,12 @@ should always be determined by the following rules:
1. If the repeated field is not a group, then its type is the element type and
elements are required.
2. If the repeated field is a group with multiple fields, then its type is the
- element type and elements are required.
-3. If the repeated field is a group with one field and is named either `array`
- or uses the `LIST`-annotated group's name with `_tuple` appended then the
- repeated type is the element type and elements are required.
+ element type and elements are required. In this case, the element type is
+ a Struct type with multiple fields.
+3. If the repeated field is a group (without annotation) with one `required` or
Review Comment:
> I think we should, but I am not clear where to add it since these lines
are all talking about LIST-annotated structures.
Perhaps around line 575 where the unannotated form is introduced. 🤷 I admit
this is a bit of an awkward location, since this file is about logical types.
Out of scope here, but perhaps a new markdown file that documents the various
ways repetition is supported would be appropriate. I know it would help me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
