etseidl commented on code in PR #466: URL: https://github.com/apache/parquet-format/pull/466#discussion_r1842484001
########## LogicalTypes.md: ########## @@ -609,6 +609,17 @@ that is neither contained by a `LIST`- or `MAP`-annotated group nor annotated by `LIST` or `MAP` should be interpreted as a required list of required elements where the element type is the type of the field. +``` Review Comment: I tend to agree, but part of me finds it odd that this language will be in `LogicalTypes.md` when without the annotation these are not logical types. But short of a new markdown file I don't know where else to put this, unless there's a section added to `README.md` devoted to how to interpret schemas. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
