wgtmac commented on code in PR #466: URL: https://github.com/apache/parquet-format/pull/466#discussion_r1843105791
########## LogicalTypes.md: ########## @@ -609,6 +609,17 @@ that is neither contained by a `LIST`- or `MAP`-annotated group nor annotated by `LIST` or `MAP` should be interpreted as a required list of required elements where the element type is the type of the field. +``` Review Comment: It looks strange to make it a subsection if the unannotated repeated fields are not deprecated. If we deprecate it, `Backward-compatibility rules` section can be organized as below: - 3-level structure with different field names - 2-level structure - Unannotated repeated fields It would be better to deprecate it in another change. Therefore I tend to keep it as is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
