wgtmac commented on PR #466: URL: https://github.com/apache/parquet-format/pull/466#issuecomment-2481322736
@etseidl I think we are on the same page that current rule 3 has an issue that it does not forbid the inner-most layer to be `repeated`. However, I feel that it is not a good idea to add `would otherwise be a valid 3-level structure as outlined above` to rule 3. The reason is that a normal 3-level structure can simply ignore its synthetic middle layer but the middle layer produces a `OneTuple` in the rule 3, which may also confuse readers. In addition, it is not that straight-forward. So I agree with @rdblue that it would be good to insert a new rule for the new case. IMO the new rule should be placed above the current rule 3 so we are pretty sure that the inner layer cannot be `repeated` in the remaining cases (including the rule 3). The only caveat is that the new rule 5 seems to be unreachable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
