rdblue commented on code in PR #461:
URL: https://github.com/apache/parquet-format/pull/461#discussion_r1853120913


##########
VariantEncoding.md:
##########
@@ -374,7 +402,7 @@ The Decimal type contains a scale, but no precision. The 
implied precision of a
 
 | Logical Type         | Physical Type               | Type ID | Equivalent 
Parquet Type     | Binary format                                                
                                                       |

Review Comment:
   Updated to clarify the columns that are Variant types.
   
   For the Parquet types, I'd prefer to keep it as is to avoid a larger table. 
Even though it mixes logical and physical types, it is unambiguous.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to