clairemcginty opened a new pull request, #3111: URL: https://github.com/apache/parquet-java/pull/3111
<!-- Thanks for opening a pull request! If you're new to Parquet-Java, information on how to contribute can be found here: https://parquet.apache.org/docs/contribution-guidelines/contributing Please open a GitHub issue for this pull request: https://github.com/apache/parquet-java/issues/new/choose and format pull request title as below: GH-${GITHUB_ISSUE_ID}: ${SUMMARY} or simply use the title below if it is a minor issue: MINOR: ${SUMMARY} --> ### Rationale for this change Fixes logical type conversions for nested records on Avro <= 1.8. This was also addressed in https://github.com/apache/parquet-java/pull/1296/files but was missing the test case where _all_ logical types are in nested classes and there are zero top-level logical types. In this case, invoking `clazz.getDeclaredField("conversions")` in AvroRecordConverter throws a `NoSuchFieldException` and terminates the loop before attempting to traverse the record's inner fields. ### What changes are included in this PR? Fixes built-in logical type conversions for Avro records that contain only nested logical type fields on <= 1.8 ### Are these changes tested? Included a test for the case described above ### Are there any user-facing changes? <!-- Please uncomment the line below and replace ${GITHUB_ISSUE_ID} with the actual Github issue id. --> <!-- Closes #${GITHUB_ISSUE_ID} --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
