RustedBones commented on code in PR #3111:
URL: https://github.com/apache/parquet-java/pull/3111#discussion_r1904145795
##########
parquet-avro/src/main/java/org/apache/parquet/avro/AvroRecordConverter.java:
##########
@@ -194,12 +194,12 @@ private static void addLogicalTypeConversion(SpecificData
model, Schema schema,
model.addLogicalTypeConversion(conversion);
}
}
-
+ } catch (NoSuchFieldException e) {
+ // Avro classes without logical types (denoted by the
"conversions" field)
+ } finally {
Review Comment:
I don't think this should be in the finally block. We should not execute
that in case of other exception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
