0x26res opened a new pull request, #3113:
URL: https://github.com/apache/parquet-java/pull/3113

   ### Rationale for this change
   
   Fix for https://github.com/apache/parquet-java/issues/3112
   
   ### What changes are included in this PR?
   
   - Uint32Value primitive / physical type switched to INT32 (from INT64)
   - Reading value for UInt32Value now uses int instead of long. In order to be 
backward compatible with previous parquet files (that were using long), I've 
left the `addLong` implementation of the  `ProtoUInt32ValueConverter`
   
   ### Are these changes tested?
   
   There was extensive test coverage of this feature for round trip reading. 
The main change is the physical / underlying type change from int32 to int64 
which is tested.
   
   There are however no test for backward compatibility.
   
   ### Are there any user-facing changes?
   
   The parquet file generated from protobuf using Uint32Value will now use 
int32 instead of int64.
   
   Closes #3112
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to