Fokko commented on code in PR #3113:
URL: https://github.com/apache/parquet-java/pull/3113#discussion_r1911401423
##########
parquet-protobuf/src/main/java/org/apache/parquet/proto/ProtoSchemaConverter.java:
##########
@@ -260,7 +260,7 @@ private <T> Builder<? extends Builder<?, GroupBuilder<T>>,
GroupBuilder<T>> addF
return builder.primitive(INT32, getRepetition(descriptor));
}
if (messageType.equals(UInt32Value.getDescriptor())) {
- return builder.primitive(INT64, getRepetition(descriptor));
+ return builder.primitive(INT32, getRepetition(descriptor));
Review Comment:
I don't think the test really test the out of bounds case. The
`Integer.MAX_VALUE` is `2^31-1 = 2147483647`, but the unsigned integer could go
up to `2^32-1 = 4294967295`. Maybe the original author @mwong38 has an opinion
on this (I'm not a protobuf expert myself).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
