zhangfengcdt commented on code in PR #2971:
URL: https://github.com/apache/parquet-java/pull/2971#discussion_r2019836792
##########
parquet-column/src/main/java/org/apache/parquet/schema/PrimitiveType.java:
##########
@@ -271,6 +271,18 @@ public Optional<PrimitiveComparator> visit(
LogicalTypeAnnotation.BsonLogicalTypeAnnotation
bsonLogicalType) {
return
of(PrimitiveComparator.UNSIGNED_LEXICOGRAPHICAL_BINARY_COMPARATOR);
}
+
+ @Override
+ public Optional<PrimitiveComparator> visit(
+ LogicalTypeAnnotation.GeometryLogicalTypeAnnotation
geometryLogicalType) {
+ return
of(PrimitiveComparator.UNSIGNED_LEXICOGRAPHICAL_BINARY_COMPARATOR);
+ }
+
+ @Override
+ public Optional<PrimitiveComparator> visit(
+ LogicalTypeAnnotation.GeographyLogicalTypeAnnotation
geographyLogicalType) {
+ return
of(PrimitiveComparator.UNSIGNED_LEXICOGRAPHICAL_BINARY_COMPARATOR);
+ }
Review Comment:
This is to add the two geo types "geometry" and "geometry" to the primitive
types for the parquet reader.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
