zhangfengcdt commented on PR #2971: URL: https://github.com/apache/parquet-java/pull/2971#issuecomment-2763665134
> @mkaravel Thanks for the great comments. > > The scope of this PR is to > > 1. Add basic type read / write of Geometry and Geography type. > 2. Add the bbox calculation of Geometry, not Geography > > I agree that, it is probably too much for this PR to do Geometry bbox wraparound and special handling of CRSs. @zhangfengcdt has some other questions related to NaN values. I'll leave those to him to ask. @mkaravel Thanks for your detailed review and they really helped. As @jiayuasu said, we have removed some logic to handle the wraparound logic in the bbox stat calculation and make this PR really just focus on basic types and simple bbox boundary calculation for geometry type. I see there were a lot of concerns about using -inf/inf as the initial states for the bbox, and we have reomved that and only keep the NaN for invalid/initial states in the bbox class. Also talking to @paleolimbot to sync this behavior with the C++ implementations as well. Hope this addresses some of your concerns, but let me know if there are still concerns or comments. Thank you again for your review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
