wgtmac commented on code in PR #3271:
URL: https://github.com/apache/parquet-java/pull/3271#discussion_r2310583175
##########
parquet-column/src/main/java/org/apache/parquet/io/ValidatingRecordConsumer.java:
##########
@@ -46,7 +48,11 @@
public class ValidatingRecordConsumer extends RecordConsumer {
private static final Logger LOG =
LoggerFactory.getLogger(ValidatingRecordConsumer.class);
+ private static final int UINT_8_MAX_VALUE = 255;
+ private static final int UINT_16_MAX_VALUE = 65535;
Review Comment:
Why only 8 and 16?
##########
parquet-column/src/main/java/org/apache/parquet/io/ValidatingRecordConsumer.java:
##########
@@ -46,7 +48,11 @@
public class ValidatingRecordConsumer extends RecordConsumer {
private static final Logger LOG =
LoggerFactory.getLogger(ValidatingRecordConsumer.class);
+ private static final int UINT_8_MAX_VALUE = 255;
+ private static final int UINT_16_MAX_VALUE = 65535;
+
private final RecordConsumer delegate;
+ private final boolean strictUnsignedIntegerValidation;
Review Comment:
Shouldn't it be validated at all times? This is already the
ValidatingRecordConsumer so it might need to validate everything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
