wgtmac commented on code in PR #3271:
URL: https://github.com/apache/parquet-java/pull/3271#discussion_r2311833506
##########
parquet-column/src/main/java/org/apache/parquet/io/ValidatingRecordConsumer.java:
##########
@@ -46,7 +48,11 @@
public class ValidatingRecordConsumer extends RecordConsumer {
private static final Logger LOG =
LoggerFactory.getLogger(ValidatingRecordConsumer.class);
+ private static final int UINT_8_MAX_VALUE = 255;
+ private static final int UINT_16_MAX_VALUE = 65535;
+
private final RecordConsumer delegate;
+ private final boolean strictUnsignedIntegerValidation;
Review Comment:
Could you help investigate why existing test break? Are all of them failed
because of unsigned integer overflow? If yes, they are actually bugs and should
be fixed in this PR so we don't have to add a separate flag for unsigned
integer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
