Jiayi-Wang-db commented on code in PR #3351:
URL: https://github.com/apache/parquet-java/pull/3351#discussion_r2459763739
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileWriter.java:
##########
@@ -1812,6 +1813,8 @@ public void end(Map<String, String> extraMetaData) throws
IOException {
LOG.debug("{}: end", out.getPos());
this.footer = new ParquetMetadata(new FileMetaData(schema,
extraMetaData, Version.FULL_VERSION), blocks);
serializeFooter(footer, out, fileEncryptor, metadataConverter);
+ } catch (Exception e) {
+ aborted = true;
Review Comment:
I’m not familiar with the direct buffer change, but in
InternalParquetRecordWriter, there’s only one place where aborted is marked. Is
that the only place that could cause an aborted write? If so, we don’t need to
apply the same pattern to every public method in `ParquetFileWriter`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
