Jiayi-Wang-db commented on code in PR #3351:
URL: https://github.com/apache/parquet-java/pull/3351#discussion_r2459793843
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileWriter.java:
##########
@@ -1812,6 +1813,8 @@ public void end(Map<String, String> extraMetaData) throws
IOException {
LOG.debug("{}: end", out.getPos());
this.footer = new ParquetMetadata(new FileMetaData(schema,
extraMetaData, Version.FULL_VERSION), blocks);
serializeFooter(footer, out, fileEncryptor, metadataConverter);
+ } catch (Exception e) {
+ aborted = true;
Review Comment:
It does look that way. The `write` function in `InternalParquetRecordWriter`
is the only public function that can throw an exception (except close). So
after we mark it as aborted there and abort the file write in the close call,
we should cover all cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
