pitrou commented on code in PR #3368:
URL: https://github.com/apache/parquet-java/pull/3368#discussion_r2597975252
##########
parquet-column/src/main/java/org/apache/parquet/column/ParquetProperties.java:
##########
@@ -756,6 +767,21 @@ public Builder withSizeStatisticsEnabled(String
columnPath, boolean enabled) {
return this;
}
+ /**
+ * Sets the compression threshold for V2 data pages.
+ *
+ * <p>When the compression ratio (compressed size / uncompressed size)
exceeds this threshold,
+ * the uncompressed data will be used instead. For example, with a
threshold of 0.98, if
+ * compression only saves 2% of space, the data will not be compressed.
+ *
+ * @param threshold the compression ratio threshold, default is {@value
#DEFAULT_V2_PAGE_COMPRESS_THRESHOLD}
+ * @return this builder for method chaining
+ */
+ public Builder withV2PageCompressThreshold(double threshold) {
Review Comment:
I'm not sure it makes sense to put "V2" in the API name? For users it
doesn't seem be relevant (just keep it mentioned in the docstrings).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
