wgtmac commented on code in PR #3368:
URL: https://github.com/apache/parquet-java/pull/3368#discussion_r2611100259
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ColumnChunkPageWriteStore.java:
##########
@@ -694,4 +731,63 @@ public void flushToFileWriter(ParquetFileWriter writer)
throws IOException {
pageWriter.writeToFileWriter(writer);
}
}
+
+ public static Builder build(BytesInputCompressor compressor, MessageType
schema, ByteBufferAllocator allocator) {
Review Comment:
Is it better to use a separate issue to implement this, though I'm fine to
keep it as is.
##########
parquet-column/src/main/java/org/apache/parquet/column/ParquetProperties.java:
##########
@@ -68,6 +68,7 @@ public class ParquetProperties {
public static final boolean DEFAULT_SIZE_STATISTICS_ENABLED = true;
public static final boolean DEFAULT_PAGE_WRITE_CHECKSUM_ENABLED = true;
+ public static final double DEFAULT_PAGE_COMPRESS_THRESHOLD = 0.98;
Review Comment:
Why is this magic number? Is it better to use a smaller number like 0.9 or
0.85?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
