emkornfield commented on code in PR #535:
URL: https://github.com/apache/parquet-format/pull/535#discussion_r2616751178
##########
Encodings.md:
##########
@@ -59,8 +62,8 @@ Dictionary page format: the entries in the dictionary using
the [plain](#PLAIN)
Data page format: the bit width used to encode the entry ids stored as 1 byte
(max bit width = 32),
followed by the values encoded using RLE/Bit packed described above (with the
given bit width).
-Using the PLAIN_DICTIONARY enum value is deprecated in the Parquet 2.0
specification. Prefer using RLE_DICTIONARY
-in a data page and PLAIN in a dictionary page for Parquet 2.0+ files.
+Using the `PLAIN_DICTIONARY` enum value is deprecated, prefer using
`RLE_DICTIONARY`.
+in a data page and PLAIN in a dictionary page for new Parquet files.
Review Comment:
removed the word prefer. I think this probably strikes the right balance.
##########
src/main/thrift/parquet.thrift:
##########
@@ -712,9 +712,16 @@ struct DictionaryPageHeader {
}
/**
- * New page format allowing reading levels without decompressing the data
+ * Alternate page format allowing reading levels without decompressing the data
* Repetition and definition levels are uncompressed
* The remaining section containing the data is compressed if is_compressed is
true
+ *
+ * Implementation note - this header is not necessarily a strict improvement
over
+ * `DataPageHeader` (in particular the original header might provide better
compression
+ * in some scenarios). Page indexes require pages start and end at row
boundaries regardless of which
+ * page header is used.
+ * https://parquet.apache.org/docs/file-format/implementationstatus/ tracks
the implementation of readers and
+ * writers that support this page format.
Review Comment:
Removed. @alamb suggested adding it but I agree we generally don't
reference it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
