alamb commented on code in PR #535:
URL: https://github.com/apache/parquet-format/pull/535#discussion_r2633204616


##########
src/main/thrift/parquet.thrift:
##########
@@ -712,9 +712,14 @@ struct DictionaryPageHeader {
 }
 
 /**
- * New page format allowing reading levels without decompressing the data
+ * Alternate page format allowing reading levels without decompressing the data

Review Comment:
   the naming of "V2" somewhat implies that it came after `DataPageHeader`
   
   What I think is confusing about the word "new" is that (to me) it implies an 
expectation that this header will eventually replace the existing one, which I 
don't think there is consensus on



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to