alamb commented on code in PR #552:
URL: https://github.com/apache/parquet-format/pull/552#discussion_r2743837006


##########
Encodings.md:
##########
@@ -25,6 +25,20 @@ This file contains the specification of all supported 
encodings.
 Unless otherwise stated in page or encoding documentation, any encoding can be
 used with any page type.
 
+### Supported Encodings
+
+| Encoding type                                    | Encoding enum             
        | Encoding Targets <br> (Parquet 2.0.0+)                                
              | Encoding Targets <br> (Parquet 1.0.0+) |

Review Comment:
   I think we have been trying to avoid the nomenclature of "parquet 2.0" as 
its definition is not universally agreed upon.
   
   I recommend we remove the separate columns and instead focus on helping 
people navigate the current version of the spec
   
   I am also not sure about the differences in different encoding targets (e.g. 
PLAIN_DICTIONARY) --- maybe we can simply not include that in the table as it 
has been deprecated?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to