alamb commented on code in PR #552:
URL: https://github.com/apache/parquet-format/pull/552#discussion_r2768859991
##########
Encodings.md:
##########
@@ -25,6 +25,25 @@ This file contains the specification of all supported
encodings.
Unless otherwise stated in page or encoding documentation, any encoding can be
used with any page type.
+### Supported Encodings
+
+| Encoding type | Encoding enum
| Supported Types
|
+| ------------------------------------------------ |
--------------------------------------------------------- |
------------------------------------------------ |
+| [Plain](#PLAIN) | PLAIN = 0
| All Physical Types
|
+| [Dictionary Encoding](#DICTIONARY) | PLAIN_DICTIONARY = 2
(Deprecated) <br> RLE_DICTIONARY = 8 | All Physical Types
|
+| [Run Length Encoding / Bit-Packing Hybrid](#RLE) | RLE = 3
| BOOLEAN
|
Review Comment:
Per
https://github.com/nkaki/parquet-format/blob/master/Encodings.md#run-length-encoding--bit-packing-hybrid-rle--3
I think this also used for encoding dictionary indices.
> Note that the RLE encoding method is only supported for the following
types of data:
>
> Repetition and definition levels
> Dictionary indices
> Boolean values in data pages, as an alternative to PLAIN encoding
```suggestion
| [Run Length Encoding / Bit-Packing Hybrid](#RLE) | RLE = 3
| BOOLEAN, Dictionary Indices
|
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
