rok commented on code in PR #241:
URL: https://github.com/apache/parquet-format/pull/241#discussion_r2877690702
##########
src/main/thrift/parquet.thrift:
##########
@@ -319,6 +319,11 @@ struct ListType {} // see LogicalTypes.md
struct EnumType {} // allowed for BYTE_ARRAY, must be encoded with UTF-8
struct DateType {} // allowed for INT32
struct Float16Type {} // allowed for FIXED[2], must be encoded as raw FLOAT16
bytes (see LogicalTypes.md)
+struct FixedSizeListType { // allowed for FIXED_LEN_BYTE_ARRAY; see
LogicalTypes.md
+ 1: required Type type; // element type (fixed-width primitive; must
not be BOOLEAN, INT96, or BYTE_ARRAY)
Review Comment:
Good point, decimal is another type we'd lose annotation for. To avoid a new
enum, how about `optional LogicalType`:
```thrift
struct FixedSizeListType {
1: required Type type; // element type (fixed-width primitive)
2: required i32 num_values;
3: optional LogicalType element_logical_type; // optional semantic
annotation of elements,
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
