rok commented on code in PR #241:
URL: https://github.com/apache/parquet-format/pull/241#discussion_r2878770027
##########
src/main/thrift/parquet.thrift:
##########
@@ -319,6 +319,11 @@ struct ListType {} // see LogicalTypes.md
struct EnumType {} // allowed for BYTE_ARRAY, must be encoded with UTF-8
struct DateType {} // allowed for INT32
struct Float16Type {} // allowed for FIXED[2], must be encoded as raw FLOAT16
bytes (see LogicalTypes.md)
+struct FixedSizeListType { // allowed for FIXED_LEN_BYTE_ARRAY; see
LogicalTypes.md
+ 1: required Type type; // element type (fixed-width primitive; must
not be BOOLEAN, INT96, or BYTE_ARRAY)
Review Comment:
> The only blocker for that is that there is no logical type annotation to
indicate FLOAT or DOUBLE.
Yes, I think we need either `Type` and `Enum` as you originally suggested or
`Type` and optional `LogicalType`. I slightly prefer `LogicalType` because we
already define it. Shall I update the language to sketch the `LogicalType` path?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
