steveloughran commented on code in PR #3512:
URL: https://github.com/apache/parquet-java/pull/3512#discussion_r3236665907
##########
parquet-column/src/main/java/org/apache/parquet/column/values/dictionary/DictionaryValuesReader.java:
##########
@@ -117,6 +117,59 @@ public long readLong() {
}
}
+ @Override
+ public void readIntegers(int[] dest, int offset, int count) {
+ try {
+ // Batch-decode dictionary IDs, then batch-lookup
+ int[] ids = new int[count];
Review Comment:
You could havve a lambda expression to catch and translate all of these, as
per org.apache.hadoop.util.functional.FunctionalIO
If you are happy with UncheckedIOException, you can use that as is, and
submit a PR saying "this shouldn't be private", which is shouldn't be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
