iemejia commented on PR #3512: URL: https://github.com/apache/parquet-java/pull/3512#issuecomment-4472737666
Closing — the JMH benchmarks and shaded jar fix from this PR have been distributed into the individual encoding/compression PRs, each of which now includes its own benchmarks: - #3565 — PLAIN (`PlainEncodingBenchmark`, `PlainDecodingBenchmark`) - #3566 — DICTIONARY (`DictionaryEncodingBenchmark`, `DictionaryDecodingBenchmark`) - #3567 — DELTA (`DeltaBinaryPackedEncodingBenchmark`, `DeltaBinaryPackedDecodingBenchmark`, `DeltaByteArrayEncodingBenchmark`, `DeltaByteArrayDecodingBenchmark`, `DeltaLengthByteArrayEncodingBenchmark`, `DeltaLengthByteArrayDecodingBenchmark`, `LongDeltaDecodingBenchmark`) - #3568 — RLE (`RleEncodingBenchmark`, `RleDecodingBenchmark`, `RleDictionaryIndexDecodingBenchmark`) - #3569 — BYTE_STREAM_SPLIT (`BssEncodingBenchmark`, `BssDecodingBenchmark`) - #3570 — Compression (`CompressionBenchmark`, `CpuReadBenchmark`, `CpuWriteBenchmark`, `FileReadBenchmark`, `FileWriteBenchmark`, `ConcurrentReadWriteBenchmark`) - #3571 — Row Group Flush (`RowGroupFlushBenchmark`) I initially submitted a series of small, focused PRs thinking they'd be easier to review. In practice the sheer number (~16 PRs, with more pending) made things harder to follow — even for me. I've regrouped the changes by encoding type / performance area so that each PR is self-contained with its own benchmarks and test coverage, which should make review and performance analysis much more straightforward. Apologies for the churn. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
