wgtmac commented on code in PR #576: URL: https://github.com/apache/parquet-format/pull/576#discussion_r3363394173
########## README.md: ########## @@ -190,11 +190,11 @@ In order we have: The value of `uncompressed_page_size` specified in the header is for all the 3 pieces combined. -The encoded values for the data page is always required. The definition and repetition levels +The encoded values for the data page are always required. The definition and repetition levels are optional, based on the schema definition. If the column is not nested (i.e. -the path to the column has length 1), we do not encode the repetition levels (it would -always have the value 1). For data that is required, the definition levels are -skipped (if encoded, it will always have the value of the max definition level). +the path to the column has length 1), we do not encode the repetition levels (they would +always have the value 0). For data that is required, the definition levels are Review Comment: I think so. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
