iemejia commented on code in PR #576: URL: https://github.com/apache/parquet-format/pull/576#discussion_r3363777063
########## Encodings.md: ########## @@ -151,7 +152,7 @@ data: * Dictionary indices * Boolean values in data pages, as an alternative to PLAIN encoding -Whether prepending the four-byte `length` to the `encoded-data` is summarized as the table below: +Whether prepending the four-byte `length` to the `encoded-data` is summarized in the table below: Review Comment: Done. ########## Compression.md: ########## @@ -48,7 +48,7 @@ No-op codec. Data is left uncompressed. A codec based on the [Snappy compression format](https://github.com/google/snappy/blob/master/format_description.txt). If any ambiguity arises when implementing this format, the implementation -provided by Google Snappy [library](https://github.com/google/snappy/) +provided by the [Snappy compression library](https://github.com/google/snappy/) Review Comment: The rationale was consistency with the other codec descriptions (e.g. GZIP says "zlib compression library" without attributing it to Jean-loup Gailly). The Snappy library link still points to Google's repo so the provenance is clear. That said, happy to revert if you prefer keeping the explicit mention. ########## README.md: ########## @@ -278,7 +278,9 @@ Changes to this core format definition are proposed and discussed in depth on th ## Code of Conduct -We hold ourselves and the Parquet developer community to a code of conduct as described by [Twitter OSS](https://engineering.twitter.com/opensource): <https://github.com/twitter/code-of-conduct/blob/master/code-of-conduct.md>. +We hold ourselves and the Parquet developer community to two codes of conduct: +1. [The Apache Software Foundation Code of Conduct](https://www.apache.org/foundation/policies/conduct.html) +2. [The Apache Software Foundation Code of Conduct for GitHub](https://github.com/apache/.github/blob/main/CODE_OF_CONDUCT.md) Review Comment: Good catch! Simplified to a single link to the ASF Code of Conduct. ########## README.md: ########## @@ -278,7 +278,9 @@ Changes to this core format definition are proposed and discussed in depth on th ## Code of Conduct -We hold ourselves and the Parquet developer community to a code of conduct as described by [Twitter OSS](https://engineering.twitter.com/opensource): <https://github.com/twitter/code-of-conduct/blob/master/code-of-conduct.md>. +We hold ourselves and the Parquet developer community to two codes of conduct: +1. [The Apache Software Foundation Code of Conduct](https://www.apache.org/foundation/policies/conduct.html) +2. [The Apache Software Foundation Code of Conduct for GitHub](https://github.com/apache/.github/blob/main/CODE_OF_CONDUCT.md) ## License Copyright 2013 Twitter, Cloudera and other contributors. Review Comment: Agreed, will handle the copyright update in a separate PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
