divjotarora commented on code in PR #584:
URL: https://github.com/apache/parquet-format/pull/584#discussion_r3455826088
##########
src/main/thrift/parquet.thrift:
##########
@@ -1195,6 +1198,18 @@ union ColumnOrder {
* or max_values indicates that all non-null values are NaN.
*/
2: IEEE754TotalOrder IEEE_754_TOTAL_ORDER;
+
+ /*
+ * The INT96 timestamp type is ordered chronologically. Only columns of
+ * physical type INT96 may use this ordering.
+ *
+ * When writing statistics for columns with INT96_TIMESTAMP_ORDER, two values
+ * must be compared as follows:
Review Comment:
Where do you recommend this go? I don't think we should remove it entirely,
the spec should clearly specify what an INT96 value means and the [nanos, days]
split i not obvious. Also I think negative values are handled as both
components are read and compared as signed integers?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
