rdblue commented on code in PR #584:
URL: https://github.com/apache/parquet-format/pull/584#discussion_r3461070436


##########
src/main/thrift/parquet.thrift:
##########
@@ -1108,20 +1120,18 @@ union ColumnOrder {
    *   BOOLEAN - false, true
    *   INT32 - signed comparison
    *   INT64 - signed comparison
-   *   INT96 (only used for legacy timestamps) - undefined(+)
+   *   INT96 (only used for legacy timestamps) - undefined or signed 
comparison of the represented value(+)

Review Comment:
   I don't understand what this means and it doesn't help anything. If the 
order is undefined or something else, but you can't tell if it is something 
else, then it's always undefined.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to