sfc-gh-nsharma commented on code in PR #585:
URL: https://github.com/apache/parquet-format/pull/585#discussion_r3501756573


##########
src/main/thrift/parquet.thrift:
##########
@@ -468,6 +468,21 @@ struct GeographyType {
   2: optional EdgeInterpolationAlgorithm algorithm;
 }
 
+/**
+ * File logical type annotation
+ *
+ * Annotates a group that represents a reference to an external file.
+ * The group must contain the following fields identified by name:
+ *   - path (STRING, required): an opaque string path to the file (e.g. 
s3://bucket/file.jpg)

Review Comment:
   If self-reference doesn't carry a requirement to preserve blocks, is there a 
huge benefit of choosing it over external references? With inline blobs, 
lifecycle of the the blob is tied with the file object. It seems like 
self-reference is giving the same lifecycle guarantee as the external 
reference. I can see that it makes the auth story simpler compared to external 
files but not if that is the main motivation for introducing it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to