emkornfield commented on code in PR #585:
URL: https://github.com/apache/parquet-format/pull/585#discussion_r3540721969
##########
src/main/thrift/parquet.thrift:
##########
@@ -468,6 +468,35 @@ struct GeographyType {
2: optional EdgeInterpolationAlgorithm algorithm;
}
+/**
+ * File logical type annotation
+ *
+ * Annotates a group that represents a reference to a file, or to a range of
+ * bytes that may be stored inline, elsewhere in this file, or in an external
+ * file. All fields are optional and are identified by name:
Review Comment:
Could we clarify terminology of:
- set - I assume this means non-null value?
- absent - Does this mean not set or the column is missing
- omitted - Does this mean not set or the column is missing
- optional - (Does this mean they have repetition level optional?
I think these might be more clearly defined in logical types. Maybe just
point readers to logical_types.md for a the full definition to avoid too much
duplication in case things change in one place or the other?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
