rdblue commented on code in PR #3610:
URL: https://github.com/apache/parquet-java/pull/3610#discussion_r3582663622
##########
parquet-column/src/test/java/org/apache/parquet/schema/TestPrimitiveComparator.java:
##########
@@ -354,6 +356,51 @@ public void
testBinaryAsSignedIntegerComparatorWithEquals() {
}
}
+ private static Binary int96(int julianDay, long nanosOfDay) {
+ return new NanoTime(julianDay, nanosOfDay).toBinary();
+ }
+
+ @Test
+ public void testInt96TimestampComparator() {
+ Binary[] valuesInAscendingOrder = {
+ int96(Integer.MIN_VALUE, 0), // most negative julian day
+ int96(-1, 86_399_999_999_999L), // negative julian days sort before day 0
+ int96(0, 0), // start of the julian period
+ int96(0, 86_399_999_999_999L), // same day, later time of day
+ int96(2440000, 123L), // 1968-05-23T00:00:00.000000123, pre-epoch but
positive julian day
+ int96(2458850, 43_200_000_000_000L), // 2020-01-01T12:00:00
+ int96(2458881, 39_600_000_000_000L), // 2020-02-01T11:00:00, later day
even though earlier time of day
+ int96(2458881, 39_600_000_000_001L), // 2020-02-01T11:00:00.000000001,
nanos tie-break
+ int96(Integer.MAX_VALUE, 86_399_999_999_999L)
+ };
+
+ for (int i = 0; i < valuesInAscendingOrder.length; ++i) {
+ for (int j = 0; j < valuesInAscendingOrder.length; ++j) {
+ assertEquals(
+ "comparing value " + i + " to value " + j,
+ Integer.signum(Integer.compare(i, j)),
+ Integer.signum(BINARY_AS_INT96_TIMESTAMP_COMPARATOR.compare(
+ valuesInAscendingOrder[i], valuesInAscendingOrder[j])));
+ }
+ }
+ }
+
+ @Test
+ public void testInt96TimestampComparatorRejectsInvalidNanos() {
+ // Same Julian day so the comparator reaches the nanos validation instead
of
+ // returning early on the day comparison.
+ Binary valid = int96(0, 0);
+ for (long invalidNanos : new long[] {-1L, Long.MIN_VALUE,
86_400_000_000_001L, Long.MAX_VALUE}) {
+ Binary invalid = int96(0, invalidNanos);
+ try {
+ BINARY_AS_INT96_TIMESTAMP_COMPARATOR.compare(valid, invalid);
+ fail("Expected IllegalArgumentException for nanos=" + invalidNanos);
Review Comment:
You can use `TestUtils.assertThrows` for this. It's in parquet-common:
parquet-common/src/test/java/org/apache/parquet/TestUtils.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
