rdblue commented on code in PR #3610:
URL: https://github.com/apache/parquet-java/pull/3610#discussion_r3582723714
##########
parquet-hadoop/src/test/java/org/apache/parquet/format/converter/TestParquetMetadataConverter.java:
##########
@@ -1413,7 +1434,29 @@ public void testColumnOrders() throws IOException {
assertEquals(
ColumnOrder.typeDefined(),
columns.get(0).getPrimitiveType().columnOrder());
assertEquals(ColumnOrder.undefined(),
columns.get(1).getPrimitiveType().columnOrder());
- assertEquals(ColumnOrder.undefined(),
columns.get(2).getPrimitiveType().columnOrder());
+ assertEquals(ColumnOrder.int96TimestampOrder(),
columns.get(2).getPrimitiveType().columnOrder());
+ }
+
+ @Test
+ public void testLegacyINT96ColumnOrder() throws IOException {
Review Comment:
Can we also check the conversion with TYPE_DEFINED_ORDER? I think you could
just create the primitive type with that specific order and then round trip to
ensure it is preserved.
I think this is a better test than the file ones that replace the footer,
since it's easier than manually editing the footer contents.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
