nastra commented on code in PR #3673: URL: https://github.com/apache/parquet-java/pull/3673#discussion_r3600740306
########## parquet-column/src/test/java/org/apache/parquet/column/values/delta/benchmark/BenchmarkReadingRandomIntegers.java: ########## @@ -33,10 +33,12 @@ import org.apache.parquet.column.values.delta.DeltaBinaryPackingValuesWriterForInteger; import org.apache.parquet.column.values.rle.RunLengthBitPackingHybridValuesReader; import org.apache.parquet.column.values.rle.RunLengthBitPackingHybridValuesWriter; -import org.junit.BeforeClass; import org.junit.Rule; -import org.junit.Test; +import org.junit.jupiter.api.BeforeAll; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.migrationsupport.rules.EnableRuleMigrationSupport; +@EnableRuleMigrationSupport Review Comment: these JUnit benchmarks depend on `com.carrotsearch.junitbenchmarks.BenchmarkRule` which is only available for JUnit4, so we can't really convert that Rule to JUnit5. We're making sure that this uses JUnit5 imports but runs with the migration module, which supports JUnit4 rule execution -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
