nastra commented on code in PR #3673:
URL: https://github.com/apache/parquet-java/pull/3673#discussion_r3601290074
##########
parquet-common/src/test/java/org/apache/parquet/bytes/TestDeprecatedBufferInputStream.java:
##########
@@ -22,141 +22,191 @@
import java.nio.ByteBuffer;
import java.util.ArrayList;
-import java.util.Arrays;
import java.util.List;
-import org.junit.Test;
-import org.junit.runner.RunWith;
-import org.junit.runners.Parameterized;
-import org.junit.runners.Parameterized.Parameter;
-import org.junit.runners.Parameterized.Parameters;
+import org.junit.jupiter.api.Nested;
+import org.junit.jupiter.api.Test;
/**
* Tests the deprecated behavior of instantiating ByteBufferInputStream
directly
*/
-@RunWith(Parameterized.class)
-public class TestDeprecatedBufferInputStream extends
TestByteBufferInputStreams {
- @Parameter(0)
- public ByteBuffer data;
-
- @Parameter(1)
- public Integer offset;
-
- @Parameters
- public static List<Object[]> parameters() {
Review Comment:
this refactors the test slightly to have nested test classes that use their
own parameters
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
