iemejia commented on code in PR #3579:
URL: https://github.com/apache/parquet-java/pull/3579#discussion_r3602664234
##########
pom.xml:
##########
@@ -605,7 +600,7 @@
</excludeModules>
<excludes>
<exclude>${shade.prefix}</exclude>
- <!-- JDK 11 adds interface methods/bridges on
PrimitiveIterator.OfInt; ignore japicmp source incompatibility -->
+ <!-- JDK adds interface methods/bridges on
PrimitiveIterator.OfInt; ignore japicmp source incompatibility -->
Review Comment:
Good question — I dug into it. It turned out not to be JDK-11-specific
behavior at all: the exclude was a workaround for a false-positive source
incompatibility that japicmp **0.23.1** reported on the synthetic/bridge
methods of `PrimitiveIterator.OfInt` (added in #3388). japicmp was upgraded to
**0.26.1** in #3592 (already on master), which handles those methods correctly.
I verified that `japicmp:cmp` (with
`breakBuildOnSourceIncompatibleModifications=true`) passes with the exclude
removed, so I removed the exclude and the comment entirely rather than reword
it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
