Fokko commented on code in PR #3579:
URL: https://github.com/apache/parquet-java/pull/3579#discussion_r3605630302
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java:
##########
@@ -1361,12 +1362,42 @@ private void readVectored(List<ConsecutivePartList>
allParts, ChunkListBuilder b
totalSize += len;
}
LOG.debug("Reading {} bytes of data with vectored IO in {} ranges",
totalSize, ranges.size());
- // Request a vectored read;
- f.readVectored(ranges, options.getAllocator());
- int k = 0;
- for (ConsecutivePartList consecutivePart : allParts) {
- ParquetFileRange currRange = ranges.get(k++);
- consecutivePart.readFromVectoredRange(currRange, builder);
+ // Use a capturing allocator to track all buffers allocated by Hadoop
during vectored reads.
Review Comment:
Thanks 👍 I don't think we should add code to Parquet to patch open issues
on Hadoop. Just cleaned up the PR, I think it is good to go now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
