stevomitric commented on code in PR #3680:
URL: https://github.com/apache/parquet-java/pull/3680#discussion_r3629574114
##########
parquet-column/src/main/java/org/apache/parquet/schema/Types.java:
##########
@@ -563,6 +563,9 @@ public Optional<Boolean> visit(
@Override
public Optional<Boolean> visit(
LogicalTypeAnnotation.TimestampLogicalTypeAnnotation
timestampLogicalType) {
+ if (primitiveType == PrimitiveTypeName.FIXED_LEN_BYTE_ARRAY) {
+ return checkFixedPrimitiveType(12, timestampLogicalType);
+ }
return checkInt64PrimitiveType(timestampLogicalType);
Review Comment:
Will this throw an error saying timestamps only support int64 physical type
- i.e. when we pass in int32? Should we extend the error message to include
FLBA as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
