emkornfield commented on code in PR #3680:
URL: https://github.com/apache/parquet-java/pull/3680#discussion_r3672045581
##########
parquet-column/src/main/java/org/apache/parquet/schema/PrimitiveStringifier.java:
##########
@@ -274,56 +310,96 @@ Instant getInstant(int value) {
;
};
+ // Converts a count of time units since epoch, held as a BigInteger (the
96-bit FLBA(12) carrier),
+ // into an Instant. The 96-bit count does not fit in a long, but the
whole-second count does, so
Review Comment:
doesn't this depend on TimeUnit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
