clairemcginty commented on code in PR #3753:
URL: https://github.com/apache/parquet-java/pull/3753#discussion_r3926779679
##########
parquet-avro/src/main/java/org/apache/parquet/avro/AvroReadSupport.java:
##########
@@ -128,6 +136,18 @@ public ReadContext init(
MessageType projection = fileSchema;
Map<String, String> metadata = new LinkedHashMap<String, String>();
+ boolean autoDetectListStructure =
+ configuration.getBoolean(AUTO_DETECT_LIST_STRUCTURE,
AUTO_DETECT_LIST_STRUCTURE_DEFAULT);
+
+ if (autoDetectListStructure
+ && configuration.get(AvroWriteSupport.WRITE_OLD_LIST_STRUCTURE) == null
Review Comment:
it would be nice to have the more modern encoding as default! though I'm a
little nervous about the implications of changing the schema for existing
datasets - I know we have some downstream use cases where a single Parquet
reader is reading a globbed filepattern matching multiple partitions of the
same dataset - not sure what would happen if some partitions used 2-level
encoding and some used 3-level encoding. Same concern about Parquet datasets
that are the source of truth for external tables in Snowflake/BigQuery/etc.
maybe I can create an issue for this and request a bit more investigation on
possible implications of this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
